fix: Point forwarding headers at the external Trino endpoint - #119
Merged
Conversation
Trino builds the absolute URLs it hands out to clients (OAuth 2.0
challenge, infoUri, ackUri) from the forwarding headers. These pointed
at trino-lb, so clients got sent to /oauth2/token/{id} on trino-lb,
which answers with a 404 and breaks the whole authentication flow.
razvan
self-requested a review
August 3, 2026 07:53
razvan
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
razvan
previously approved these changes
Aug 3, 2026
razvan
left a comment
razvan
left a comment
Member
There was a problem hiding this comment.
A couple of small remarks, otherwise it lgtm.
razvan
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SUP-386
Trino builds the absolute URLs it hands out to clients (OAuth 2.0 challenge, infoUri, ackUri) from the forwarding headers. These pointed at trino-lb, so clients got sent to /oauth2/token/{id} on trino-lb, which answers with a 404 and breaks the whole authentication flow.